feat: Added asynchronous methods and context propagation #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad66b57.
sks1995
reviewed
Aug 13, 2025
src/main/java/com/intuit/springwebclient/client/CommonSpringWebClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/intuit/springwebclient/client/CommonSpringWebClient.java
Outdated
Show resolved
Hide resolved
sks1995
reviewed
Aug 18, 2025
| @@ -10,6 +10,7 @@ public final class ClientHttpResponse<T>{ | |||
|
|
|||
| private final T response; | |||
| private final String error; | |||
| private final Exception exception; | |||
There was a problem hiding this comment.
ideally it should be Throwable
sks1995
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
[Link to JIRA]
Thank you!